feat: add linter (2949) #3053
Merged
feat: add linter (2949) #3053
+28
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
… to nolint ignore them Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…anic Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…gnore it Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…r before loop Signed-off-by: Kit Patella <[email protected]>
…caller Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Codecov ReportAttention: Patch coverage is
|
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
schristoff
previously approved these changes
Oct 3, 2024
AustinAbro321
previously approved these changes
Oct 3, 2024
Co-authored-by: Austin Abro <[email protected]>
AustinAbro321
approved these changes
Oct 3, 2024
mjnagel
pushed a commit
to mjnagel/zarf
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Kit Patella <[email protected]> Co-authored-by: Austin Abro <[email protected]> Signed-off-by: Micah Nagel <[email protected]>
ittacco
pushed a commit
to ittacco/zarf
that referenced
this pull request
Nov 9, 2024
Signed-off-by: Kit Patella <[email protected]> Co-authored-by: Austin Abro <[email protected]> Signed-off-by: ittacco <[email protected]>
Jneville0815
pushed a commit
to radiusmethod/zarf
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Kit Patella <[email protected]> Co-authored-by: Austin Abro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the work in the other PRs that store and return errors from various empty and ignored returns. It should be merged after #2993 to ensure we don't add the lint rule before it's fulfilled and create a dirty CI state on main.
Related Issue
Fixes #2949
Depends on #2993
Relates to #2953
Checklist before merging